feat: Namespace for named types defined by this library#558
Merged
Conversation
martin-g
approved these changes
Jun 18, 2026
Kriskras99
force-pushed
the
feat/namespace_for_named_types
branch
from
51aa528 to
cabde71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the enum generation I realised it would be useful to put the Avro types we define into their own namespace. This allows users to use their own
Duration/u64/... types and we are free to implementAvroSchemafor more Rust types if we're inclined to do so without breaking user code (unless they use theorg.apache.avro.rustnamespace but then it's their own problem).