fix: Optimize Alias::new() and Parser::fix_aliases_namespace#557
Merged
Conversation
martin-g
approved these changes
Jun 18, 2026
Member
|
Maybe the PR title should be |
Kriskras99
force-pushed
the
fix/optimize_alias_new
branch
from
f3b98e6 to
b152367
Compare
Contributor
Author
|
I've renamed it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a missed optimization opportunity.
Using
impl Into<String> + AsRef<str>allows us to reuse the allocation if the input is aString.And by using
.into_iter()infix_aliases_namespacewe get an allocation we can reuse.