[Variant] VariantArray field API naming#10124
Open
sdf-jkl wants to merge 1 commit into
Open
Conversation
sdf-jkl
commented
Jun 11, 2026
| self.shredding_state.typed_value_column() | ||
| } | ||
|
|
||
| /// Return the [`FieldRef`] of the `metadata` column of the [`StructArray`] |
Contributor
Author
There was a problem hiding this comment.
Now that I look at it the new _field APIs would only be used for tests in #10015.
// before reuse StructArray::field_by_name (#10110), returns Option<&FieldRef>
let typed_value_field = variant_array.inner().field_by_name("typed_value").unwrap();
// new — the new VariantArray sugar, returns Option<&FieldRef> (no .inner(), no magic string)
let typed_value_field = variant_array.typed_value_field().unwrap();Is it worth introducing for 4 calls in tests?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
VariantArrayfield API naming #10093.Rationale for this change
check issue
What changes are included in this PR?
_fieldAPIs that return&ArrayRefto_column_fieldAPIs that return&FieldRefand tests for themAre these changes tested?
Are there any user-facing changes?