fix(parquet): return error instead of panicking in pad_nulls on corrupt input#10108
Open
thepenguinco wants to merge 1 commit into
Open
fix(parquet): return error instead of panicking in pad_nulls on corrupt input#10108thepenguinco wants to merge 1 commit into
thepenguinco wants to merge 1 commit into
Conversation
…pt input ValuesBuffer::pad_nulls asserted internal invariants that corrupt parquet data can violate, panicking instead of surfacing a decode error. Change pad_nulls to return Result and convert the assertions in OffsetBuffer and FixedLenByteArrayBuffer into ParquetError::General, propagating at the record reader call site. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ValuesBuffer::pad_nulls asserted internal invariants that corrupt parquet data can violate, panicking instead of surfacing a decode error.
What changes are included in this PR?
Change pad_nulls to return Result and convert the assertions in OffsetBuffer and FixedLenByteArrayBuffer into ParquetError::General, propagating at the record reader call site.
Are these changes tested?
Adds a regression test.
Are there any user-facing changes?
No breakages to public API, just returns decode Err instead of panicking.