Register arrow to substrait boolean functions. Add support for "xor" … #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we add a test for this? |
Author
|
Sure, I will add some test |
Member
|
@ostafen any update here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Previously, boolean function were not registered for arrow-to-substrate conversion. This could cause
not founderrors.What changes are included in this PR?
This PR registers
Arrow-to-Substraitfor the boolean operatorsand,orandnot. It also add conversion functions for thexoroperator.Are these changes tested?
There are currently no explicit unit tests added in this PR. Existing integration tests that involve these boolean operators in Arrow expressions should now pass conversion to Substrait correctly. Additional targeted tests may be added later to cover these mappings explicitly.
Are there any user-facing changes?
No direct user-facing changes.