Add TCK test run with ZooKeeper discovery and Fastbin distribution provider#119
Open
amichair wants to merge 9 commits into
Open
Add TCK test run with ZooKeeper discovery and Fastbin distribution provider#119amichair wants to merge 9 commits into
amichair wants to merge 9 commits into
Conversation
added 9 commits
May 25, 2026 16:11
…ribution provider
amichair
changed the title
alien11689
approved these changes
May 26, 2026
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(FastBinProvider.class); | ||
|
|
||
| static final String[] SUPPORTED_INTENTS = { "tck.test" }; // at least one intent required by TCK |
Contributor
There was a problem hiding this comment.
is exactly the value tck.test necessary? or should we use some placeholder value specific for our implementation?
Contributor
Author
There was a problem hiding this comment.
No, it's a dummy value, I just picked something that's clear it's related to the tck test and obviously not a real one. If you have a better suggestion I'll change it, it doesn't really matter.
Contributor
There was a problem hiding this comment.
maybe?
static final String[] DEFAULT_NOT_EMPTY_INTENTS = { "aries.rsa.default" };
BTW we should make the comment a javadoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the fixes necessary for the zookeeper discovery and fastbin providers to pass the TCK tests.
Regarding the commit fixing fastbin not shutting down properly, if you have a more elegant way of solving this please do share... (I have no previous experience with hawtdispatch).