feat(file-logger): add path properties to file-logger plugin metadata#12825
Merged
Baoyuantop merged 4 commits intoapache:masterfrom Dec 30, 2025
Merged
Conversation
Baoyuantop
previously approved these changes
Dec 22, 2025
AlinsRan
previously approved these changes
Dec 25, 2025
ronething
reviewed
Dec 25, 2025
| return metadata.value.path | ||
| end | ||
|
|
||
| return nil, "property \"path\" is required" |
Contributor
There was a problem hiding this comment.
We have removed required = {"path"}, but it returns is required when path is empty. can we add something like neither the metadata nor the conf is configured
Contributor
There was a problem hiding this comment.
Hi @TaeyeongKwak, I submitted a suggested change and committed suggestion for this comment, but it seems the error message in the test also needs to be fixed. Could you please help me with that? It's located in t/plugin/file-logger.t. (TEST 1)
Contributor
Author
There was a problem hiding this comment.
@Baoyuantop, I’ve fixed the error message in the test you mentioned.
Baoyuantop
reviewed
Dec 25, 2025
2ccf531
Baoyuantop
approved these changes
Dec 29, 2025
AlinsRan
approved these changes
Dec 29, 2025
ronething
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
pathsupport to the file-logger plugin metadata, allowing a default log file path to be configured globally via plugin_metadata and used when an individual plugin config does not specify path.For example, a user can set a path through plugin metadata, as below:
As above, if the path properties exists in the plugin metadata, you can exclude the path properties of the file-logger plugin when setting the route.
Checklist