[AMORO-4034][Improvement]: MaintainerMetrics Unified interface and Report #4045
[AMORO-4034][Improvement]: MaintainerMetrics Unified interface and Report #4045czy006 wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4045 +/- ##
============================================
- Coverage 28.63% 22.49% -6.15%
+ Complexity 3942 2571 -1371
============================================
Files 654 460 -194
Lines 52293 42285 -10008
Branches 6621 5933 -688
============================================
- Hits 14973 9511 -5462
+ Misses 36230 31955 -4275
+ Partials 1090 819 -271
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4468f3 to
0cfa9a4
Compare
majin1102
left a comment
There was a problem hiding this comment.
Thanks for working on this. Left some comments
...ceberg/src/main/java/org/apache/amoro/formats/iceberg/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
...ceberg/src/main/java/org/apache/amoro/formats/iceberg/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/table/AbstractTableMaintainerMetrics.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/table/AbstractTableMaintainerMetrics.java
Outdated
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/maintainer/MaintainerOperationTemplate.java
Outdated
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/maintainer/MaintainerOperationTemplate.java
Outdated
Show resolved
Hide resolved
...ceberg/src/main/java/org/apache/amoro/formats/iceberg/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/maintainer/MaintainerOperationTemplate.java
Outdated
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/maintainer/MaintainerOperationTemplate.java
Outdated
Show resolved
Hide resolved
d69deba to
c63f243
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions. |
1853680 to
3eb6d57
Compare
[Improvement]: MaintainerMetrics Unified interface and Report (#4034)
Why are the changes needed?
Close #4034 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation