Skip to content

[AMORO-SITE-63] Enhance the version bump logic when releasing#64

Merged
zhoujinsong merged 1 commit intomasterfrom
version_bump_when_releasing
Oct 9, 2025
Merged

[AMORO-SITE-63] Enhance the version bump logic when releasing#64
zhoujinsong merged 1 commit intomasterfrom
version_bump_when_releasing

Conversation

@klion26
Copy link
Member

@klion26 klion26 commented Sep 25, 2025

This fix #63 .
It wants to enahcne the version bump logic in release guide

@klion26
Copy link
Member Author

klion26 commented Sep 25, 2025

cc @zhoujinsong @xxubai

Change the project version to the release version in the `tools/change-version.sh`:
Checkout a `patch` branch using the following command
```
$ git checkout -b 0.8.0-branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am not sure why we need a patch branch to change the project version.

Can we change it in the release branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't change the version to a release version (without the suffix of SNAPSHOT) in branch like 0.8.x, because the code in 0.8.x branch isn't 0.8.0-incubating(we may bump to 0.8.1-incubating if we have another patch version).

The version in 0.8.x need to be 0.8-SNAPSHOT(after branch 0.8.x has been cut, the version in master need to be upgraded to 0.9-SNAPSHOT), because we'll checkout 0.8.0-incubating, 0.8.1-incubating(and other patch version for 0.8 if needed) from 0.8.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@zhoujinsong zhoujinsong merged commit a7a813e into master Oct 9, 2025
3 checks passed
@zhoujinsong zhoujinsong deleted the version_bump_when_releasing branch October 9, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance the version bump logic in release guide

2 participants