[AMORO-3404] Correct the description about MySQL usage#48
Merged
zhoujinsong merged 2 commits intomasterfrom Jan 22, 2025
Merged
[AMORO-3404] Correct the description about MySQL usage#48zhoujinsong merged 2 commits intomasterfrom
zhoujinsong merged 2 commits intomasterfrom
Conversation
Member
Author
|
@justinmclean @zhoujinsong please help to review this when you're free, thanks. |
The lincense of MySQL is incompatible with Apache Lincese, we need to correct the descriptions This closes apache/amoro#3404
klion26
force-pushed
the
correct-mysql-usage-desc
branch
from
2766fce to
a053083
Compare
zhoujinsong
reviewed
Jan 21, 2025
Contributor
zhoujinsong
left a comment
zhoujinsong
left a comment
There was a problem hiding this comment.
@klion26 Thanks for the work!
I left some comments, PTAL.
Member
Author
|
@zhoujinsong comments have been addressed, please take another look when you're free, thanks. |
zhoujinsong
approved these changes
Jan 21, 2025
Contributor
zhoujinsong
left a comment
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
You may want to copy the changes to the main repo.
actually, we manage the docs in the main repo and copied to the site repo when we released a new version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lincense of MySQL is incompatible with Apache Lincese, we need to correct the descriptions
This closes apache/amoro#3404