Fix Task SDK silently ignoring AirflowRuntimeError when Variable.set() or Variable.delete() fails#68542
Open
jayachandrakasarla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68537
As per the issue,
Variable.set()andVariable.delete()in the Task SDK were silently ignoring AirflowRuntimeError, logging the exception but not re-raising, causing tasks to report success even when a variable write was rejected by the Execution API.Added
raiseto both except blocks so errors now propagate and fail the task, consistent with the existing behavior ofVariable.get().Also added the unit tests:
test_var_set_raises_on_runtime_error- verifiesVariable.set()re-raisesAirflowRuntimeErrorwhen the underlying call fails (e.g. a 403 from the API server).test_var_delete_raises_on_runtime_error- same forVariable.delete().test_var_delete- basic success-path coverage forVariable.delete(), which was previously untested.Here's a DAG for testing:
Use the following middleware plugin with breeze to test 403 API errors
Was generative AI tooling used to co-author this PR?
[X] Yes
Used Claude to generate the middleware plugin to test 403 API errors.