Fix Go worker heartbeat cancellation handling#68535
Open
jx2lee wants to merge 1 commit into
Open
Conversation
jx2lee
force-pushed
the
jx2lee/gosdk-handle-hearbeat-cancellation
branch
from
87b8c84 to
14b7656
Compare
jx2lee
force-pushed
the
jx2lee/gosdk-handle-hearbeat-cancellation
branch
from
14b7656 to
972b026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worker cancels the task context with
ErrTaskCancelledAfterFailedHeartbeat, but final state handling checkedtaskContext.Err()instead ofcontext.Cause(...). This could miss the cancellation reason and report the wrong final state.Added a worker test for the 409 heartbeat cancellation path.
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines