Skip to content

Fix layout overflow issue in DAG Details Logs tab #64013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Revanth14 wants to merge 1 commit into
base: v2-11-stable
Choose a base branch
from
+16 −15
Open

Fix layout overflow issue in DAG Details Logs tab #64013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions airflow/www/static/js/dag/details/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,11 @@ const Details = ({
<Tabs
size="lg"
isLazy
height="100%"
display="flex"
flexDirection="column"
flex={1}
minH={0}
overflow="hidden"
index={tabIndex}
onChange={onChangeTab}
>
Expand Down Expand Up @@ -425,8 +429,8 @@ const Details = ({
</Button>
)}
</TabList>
<TabPanels height="100%">
<TabPanel height="100%">
<TabPanels flex={1} overflowY="auto">
<TabPanel>
{isDag && <DagContent />}
{isDagRun && <DagRunContent runId={runId} />}
{!!runId && !!taskId && (
Expand Down Expand Up @@ -460,23 +464,23 @@ const Details = ({
runId={runId}
/>
</TabPanel>
<TabPanel height="100%">
<TabPanel>
<DagCode />
</TabPanel>
<TabPanel height="100%">
<TabPanel>
<EventLog
taskId={isGroup || !taskId ? undefined : taskId}
showMapped={isMapped || !taskId}
run={run}
/>
</TabPanel>
{isDag && (
<TabPanel height="100%">
<TabPanel>
<RunDuration />
</TabPanel>
)}
{isDag && (
<TabPanel height="80%">
<TabPanel>
<Flex justifyContent="right" pr="30px">
<Checkbox
isChecked={showBar}
Expand All @@ -491,15 +495,12 @@ const Details = ({
</TabPanel>
)}
{isDag && (
<TabPanel height="100%" width="100%" overflow="auto">
<TabPanel p={0}>
<Calendar />
</TabPanel>
)}
{isTaskInstance && run && (
<TabPanel
pt={mapIndex !== undefined ? "0px" : undefined}
height="100%"
>
<TabPanel pt={mapIndex !== undefined ? "0px" : undefined}>
<BackToTaskSummary
isMapIndexDefined={mapIndex !== undefined}
onClick={() => onSelect({ runId, taskId })}
Expand All @@ -520,7 +521,7 @@ const Details = ({
</TabPanel>
)}
{isMappedTaskSummary && (
<TabPanel height="100%">
<TabPanel>
<MappedInstances
dagId={dagId}
runId={runId}
Expand All @@ -532,7 +533,7 @@ const Details = ({
</TabPanel>
)}
{isTaskInstance && (
<TabPanel height="100%">
<TabPanel>
<XcomCollection
dagId={dagId}
dagRunId={runId}
Expand All @@ -543,7 +544,7 @@ const Details = ({
</TabPanel>
)}
{isTaskInstance && isK8sExecutor && (
<TabPanel height="100%">
<TabPanel>
<RenderedK8s />
</TabPanel>
)}
Expand Down
Loading