Skip to content

Conversation

@kenliao94
Copy link
Contributor

@kenliao94 kenliao94 commented Dec 9, 2025

  • Removed components that are no longer referenced.
  • Removed "classic" from FAQ and support pages.

@kenliao94
Copy link
Contributor Author

Tested locally to make sure the removal of those components will not cause crashes or dead links

@jbonofre jbonofre self-requested a review December 9, 2025 09:44
@gemmellr
Copy link
Member

gemmellr commented Dec 9, 2025

I already opened #169 about 3.75 days ago including the major change here of removing the artemis components content, which I worked on along with some accommodating changes on the new Artemis site following the log comment of my previous commit [message] that it did a surface level 'hiding' of Artemis and did not remove this not-unused component content at the time so as to not immediately break all existing external links to it.

My PR obviously makes similar removals, but also makes further changes to simplify the site build itself to also remove Artemis related config, and in stark contrast to these changes also makes some changes to the redirects so that it doesnt immediately outright break every existing external link as this simplified removal does, which is why it was mentioned as not being done yet in my earlier changes last week.

I will merge #169 now. You will need to update this PR to handle the conflict and retain your other smaller changes.

@jbonofre
Copy link
Member

jbonofre commented Dec 9, 2025

@gemmellr that makes sense. This PR should be rebased after #169

@gemmellr
Copy link
Member

gemmellr commented Dec 9, 2025

I have merged the earlier PR, and surprisingly enough it seems like its happy to proceed with this one as the commonality is all removals. I still think this should be rebased first anyway, so that its actually possible to see what is being changed.

@jbertram
Copy link
Contributor

jbertram commented Dec 9, 2025

Tested locally to make sure the removal of those components will not cause crashes or dead links

I think you didn't consider all the folks who have bookmarks or history entries that they use to get the existing content. This change would break all that.

@kenliao94
Copy link
Contributor Author

Thanks @gemmellr, sorry i didn't realize about that PR you opened. I am going to rebase it and keep only wording changes.

@kenliao94 kenliao94 changed the title Update more wording and remove unused components Updated wording on support and faq pages Dec 9, 2025
@kenliao94
Copy link
Contributor Author

@gemmellr @jbertram @jbonofre I rebased my branch. Please take another look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants