implemement diff generation as build CLI arg (all commits)#39
Merged
pmolodo merged 6 commits intoaousd:mainfrom Mar 11, 2026
Merged
implemement diff generation as build CLI arg (all commits)#39pmolodo merged 6 commits intoaousd:mainfrom
pmolodo merged 6 commits intoaousd:mainfrom
Conversation
Contributor
OleksiyPuzikov
left a comment
OleksiyPuzikov
left a comment
There was a problem hiding this comment.
LGTM, awesome progress!
| cwd=self.get_repo_root(), | ||
| ) | ||
| builder = self.__class__(repo_root=worktree_path) | ||
| ref_args = types.SimpleNamespace( |
| if json.dumps(list_a[i - 1], sort_keys=True) == json.dumps( | ||
| list_b[j - 1], sort_keys=True | ||
| ): | ||
| if a_strs[i - 1] == b_strs[j - 1]: |
Contributor
There was a problem hiding this comment.
Good find, thanks! :)
pmolodo
force-pushed
the
diff_speedup
branch
2 times, most recently
from
87f999d to
80675c8
Compare
pmolodo
changed the title
Contributor
Author
Just to clarify before crossing the rubicon - does this mean you're ok with merging this branch into main immediately, and all it's commits? |
This was referenced Mar 9, 2026
Merged
Contributor
|
Yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the all-in-one PR that shows all the commits / changes related to diff generation. ie, it is the accumlation of these per-commit PRs: