Closed
Conversation
Owner
|
Thank you for putting this. I think this is a bug somewhere else in the code. I need to get to the bottom of it. |
Contributor
Author
pull_line() can return NULL, so this needs to be checked, right? |
Owner
|
I am a bit blurry here. I think it is being called on a non-existing comp_num; if I recall correctly, this should not happen. |
Owner
|
I tracked it down. The commit is messy because endline spaces are removed. Remove the lines that repeat this line. |
Owner
|
This was solved another way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4536793000378368