Skip to content

Conversation

@mphemming
Copy link

@mphemming mphemming commented Sep 9, 2025

I also tested creating a LTSP and worked as expected.

The failing pytest was due to xarray==2025.9.1. When testing locally in my virtual environment it passed with xarray==2025.3.1. I changed the setup.py to reflect this, but GH actions don't seem to run when the base is the V2 branch.

@mphemming mphemming changed the base branch from master to v2 September 9, 2025 01:54
@mphemming mphemming changed the base branch from v2 to master September 9, 2025 03:28
@mphemming mphemming changed the base branch from master to v2 September 9, 2025 03:29
@mphemming mphemming requested a review from mhidas September 9, 2025 03:41
@mhidas
Copy link
Contributor

mhidas commented Sep 9, 2025

but GH actions don't seem to run when the base is the V2 branch.

It's configured to run only on PR and push into the master branch (see lines 5 & 7 of the workflow)

Since we're now effectively making v2 the new main branch, we should add:

on:
  push:
    branches: [ master, v2 ]
  pull_request:
    branches: [ master, v2 ]

@mphemming
Copy link
Author

but GH actions don't seem to run when the base is the V2 branch.

It's configured to run only on PR and push into the master branch (see lines 5 & 7 of the workflow)

Since we're now effectively making v2 the new main branch, we should add:

on:
  push:
    branches: [ master, v2 ]
  pull_request:
    branches: [ master, v2 ]

that worked, thanks!

@mphemming mphemming merged commit 230cde6 into v2 Sep 9, 2025
1 check passed
@mphemming mphemming deleted the 7287-flag_values-convert-to-bytes branch September 9, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants