Fix profile response fields and add bio validation (#13)#78
Open
learnercloudtech wants to merge 4 commits intoanxkhn:mainfrom
Open
Fix profile response fields and add bio validation (#13)#78learnercloudtech wants to merge 4 commits intoanxkhn:mainfrom
learnercloudtech wants to merge 4 commits intoanxkhn:mainfrom
Conversation
Updated the bio field to use Pydantic's Field with a maximum length constraint.
…ehavior to pass all tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple issues to align the Workshop API with the test suite and Issue #13.
Changes
max_length=500validation to thebiofield inProfileCreate.ProfileResponseto include bothnameandusernamefor consistency with tests./healthendpoint to return 200 OK with {"status": "ok"}./sumendpoint to perform addition instead of multiplication./searchendpoint to return all profiles when query is empty.Validation
pytest tests/ -v→ all 9 tests passedIssue Reference
Closes #13