Skip to content

av/614_fix_logout_url_retrieve_issue #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjwgit merged 1 commit into from
Mar 19, 2026
Merged

av/614_fix_logout_url_retrieve_issue #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/src/solid/utils/misc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,10 @@ Future<bool> logoutPod() async {
await KeyManager.clear();
debugPrint('logoutPod() => KeyManager.clear() completed');

// Step 2: Remove authentication data from secure storage
// Step 2: Get the logout URL before removing auth data
final logoutUrl = await AuthDataManager.getLogoutUrl();

// Step 3: Remove authentication data from secure storage
// This is CRITICAL - must succeed
final authDataRemoved = await AuthDataManager.removeAuthData();
if (!authDataRemoved) {
Expand All @@ -463,7 +466,7 @@ Future<bool> logoutPod() async {
// Don't return false yet - logout endpoint is still needed
}

// Step 2.5: Clear application-specific caches BEFORE network call
// Step 3.5: Clear application-specific caches BEFORE network call
// This is CRITICAL to prevent race conditions where UI reads stale cache
// during logout, especially when network is slow
if (_onLogoutClearCaches != null) {
Expand All @@ -479,9 +482,8 @@ Future<bool> logoutPod() async {
debugPrint('logoutPod() => No application cache callback registered');
}

// Step 3: Get the logout URL and attempt OAuth2 logout
// Step 4: Attempt OAuth2 logout
// This is OPTIONAL - should not block if it fails
final logoutUrl = await AuthDataManager.getLogoutUrl();
if (logoutUrl != null && logoutUrl.isNotEmpty) {
try {
// Call the OAuth2 logout endpoint
Expand Down
Loading