Skip to content

resolve initialization failure when encryption directory exists#605

Open
Miduo666 wants to merge 2 commits intoanusii:devfrom
Miduo666:miduo/604_enable_reinitialization
Open

resolve initialization failure when encryption directory exists#605
Miduo666 wants to merge 2 commits intoanusii:devfrom
Miduo666:miduo/604_enable_reinitialization

Conversation

@Miduo666
Copy link
Contributor

Pull Request Details

What issue does this PR address

  • [Description]

Associated Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@gjwgit gjwgit requested review from cdawei and tonypioneer February 28, 2026 22:54
Copy link
Contributor

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be tested to ensure all continue to work as expected. Generally seems to be working. Good to have a check from @tonypioneer and @cdawei.

  • geopod
  • notepod
  • healthpod
  • movistar
  • riopod
  • riodash
  • innerpod - it is starting up as if I had not already initialised the app? Now back on dev it is doing the same, though before trying this PR it was loading just fine.

@gjwgit gjwgit removed request for cdawei and tonypioneer March 1, 2026 01:04
@Miduo666
Copy link
Contributor Author

Miduo666 commented Mar 1, 2026

Needs to be widely tested across multiple apps to ensure all continue to work as expected.

  • geopod
  • innerpod - it is starting up as if I had not already initialised the app? Now back on dev it is doing the same, though before trying this PR it was loading just fine.

Hi Graham,

Thank you for the detailed feedback.

I have tested the PR on notepod as well, and it is working correctly without triggering a re-initialization.

A typical test case is to modify app.dart as shown in the attached screenshot. You can try adding a new directory to the customFolderPathList and verify if the app handles the initialization as expected without regressing existing setups.
image

I will continue to investigate why innerpod specifically is failing to recognize its initialized state.

@gjwgit
Copy link
Contributor

gjwgit commented Mar 1, 2026

THanks. It may be that innerpod is an older app and not correctly using the new functionality.

@gjwgit gjwgit requested review from cdawei and tonypioneer March 1, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants