feat: enhance contextmenu behavior and styling#7617
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在提升 G6 图编辑器的上下文菜单用户体验。通过限制菜单的显示位置，确保其不会超出画布边界，并允许菜单内容在必要时垂直滚动，同时阻止菜单上的滚轮事件干扰画布的缩放功能。这些改进使得上下文菜单在交互上更加稳定和用户友好。 Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| const menuHeight = this.$element.offsetHeight; | ||
| const containerWidth = clientRect.width; | ||
| const containerHeight = clientRect.height; | ||
| const padding = 4; |
There was a problem hiding this comment.
这里的 padding 值 4 是一个“魔数”(magic number)。为了提高代码的可读性和可维护性，建议将其定义为常量。另外，这个值与 util.ts 文件中 CONTEXTMENU_CSS 里 max-height 的 8px 相关（8 = 4 * 2）。考虑将此值定义在一个共享的位置（例如 util.ts 中），以便在两个文件中统一引用，确保一致性。
| overflow: hidden; | ||
| overflow-x: hidden; | ||
| overflow-y: auto; | ||
| max-height: calc(100% - 8px); |
There was a problem hiding this comment.
这里的 8px 是一个“魔数”(magic number)。它似乎是 index.ts 中用于边界检查的 padding 值的两倍。建议将 padding 值定义为共享常量，并在此处通过计算得出 max-height，例如 max-height: calc(100% - ${PADDING * 2}px);。这样可以确保两处逻辑的一致性，并提高代码的可维护性。
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5 #7617 +/- ##
==========================================
- Coverage 94.95% 94.95% -0.01%
==========================================
Files 188 188
Lines 10014 10031 +17
Branches 2171 2171
==========================================
+ Hits 9509 9525 +16
- Misses 505 506 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
3 participants
ContextMenu 功能增强
限制菜单位置，防止超出画布范围，限制ContextMenu最大高度不超过画布高度，并允许滚动