Set encoding to utf-8 when opening files#2
Open
paulfioravanti wants to merge 1 commit into
Open
Conversation
Explicitly set file encoding to utf-8 when opening files in order to avoid inexplicable errors like the following when importing Markdown steno dictionaries in Windows: ``` 'charmap' codec can't decode byte 0x90 in position 6009398: character maps to <undefined> ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After building up my steno dictionaries on macOS, I had cause to install Plover on Windows, and hence tried importing my dictionaries there. Three of them ended up being unable to be imported due to incomprehensible errors that looked like the following:
Explicitly setting file encoding to
"utf-8"when opening files made the errors go away, and enabled the dictionaries to be imported successfully.Thanks for making this plugin! Pretty much all my steno dictionaries are in Markdown :)