optimize populate_startup_nodes method#11
Open
pathbox wants to merge 1 commit intoantirez:masterfrom
pathbox:master
Open
optimize populate_startup_nodes method#11pathbox wants to merge 1 commit intoantirez:masterfrom pathbox:master
pathbox wants to merge 1 commit intoantirez:masterfrom
pathbox:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi antirez,
How do you do? I build the redis cluster for work recently. Then I read the source code in
redis-rb-clusterseriously. Yeah, I am a Rubist. I findpopulate_startup_nodesmethod in cluster.rb that it can be optimized.In
populate_startup_nodesmethod, this lineIt run 16384 times
@startup_nodes << n, I optimize this,@cluster_slotsis array, and its size is startup_nodes's size. Mystartup_nodesis@cluster_slots.each do |item|just run 3 times.And I puts the
@startup_nodes.uniq!, the result is same as old code.Please review my code, if you think it is good, you can merge the pull request.
I'm happy to do this.