fix(forge_config): make global config file optional#2699
Merged
tusharmath merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a missed case from the config refactor where the global TOML config file was required to be present, causing failures when it doesn't exist.
Context
PR #2685 introduced the
forge_configcrate as part of a config refactor. During that refactor, theread_globalmethod was added toConfigReader, but the config file source was registered as required — meaning Forge would fail to start if the global config file (forge.toml) was absent. Since the global config file is optional by design, this was an oversight.Changes
required(false)so Forge starts normally even when the file does not existTesting
Links
.forge.tomlsupport #2685