[WIP] Add TypeScript declaration files to output#204
Draft
EdricChan03 wants to merge 1 commit intoantimatter-dimensions:masterfrom
Draft
[WIP] Add TypeScript declaration files to output#204EdricChan03 wants to merge 1 commit intoantimatter-dimensions:masterfrom
EdricChan03 wants to merge 1 commit intoantimatter-dimensions:masterfrom
Conversation
Collaborator
|
Is this PR also mergeable? |
Contributor
Author
I've not (yet) tested if the typings are actually usable. Additionally, community notation typings are also generated but won't work if the community notations aren't actually imported so this may require a general restructure of how community notations would be consumed |
a6e983d to
f653546
Compare
f653546 to
a39e762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces declaration files to the output. The changes include:
./dist/types.package.jsonsuch that the TS compiler can detect the declaration files (as indicated in the TypeScript docs for publishing declaration files).Caveats
The typings currently don't include the community notations.
Additional notes
src/community/infix-abstract.tswhich broke the buildCloses #150