Add linked descriptor types for runtime reflection#9
Draft
Conversation
Moves the generated FileDescriptorProto/DescriptorProto types and vendored descriptor.proto sources from buffa-codegen into a new buffa-descriptor crate that depends only on buffa. This makes the descriptor types available without pulling in quote/syn/prettyplease, laying the foundation for runtime reflection. buffa-codegen re-exports buffa_descriptor::generated so all existing crate::generated:: paths resolve unchanged. gen_descriptor_types now takes an explicit output directory argument, eliminating the previous cwd-sensitivity.
iainmcgin
force-pushed
the
buffa-descriptor-crate
branch
from
93b88c2 to
e1e0949
Compare
Introduces MessageDescriptor, FieldDescriptor, EnumDescriptor and supporting types as the processed, feature-resolved layer on top of the raw FileDescriptorProto tree. Where raw protos use string type_name references and unresolved FeatureSet options, these use pool indices (MessageIndex/EnumIndex, avoiding Arc cycles) and pre-resolved edition features (FieldPresence, packed, delimited). FieldKind flattens protobuf's type × label × map-entry axes into a single Copy discriminant via a SingularKind sub-enum — invalid states like List(List(...)) are unrepresentable, and no Box allocation is needed. These types are constructed by DescriptorPool (next PR) and consumed by DynamicMessage. #[non_exhaustive] with pub fields allows reads without external construction.
iainmcgin
force-pushed
the
buffa-descriptor-linked-types
branch
from
21128f0 to
75f320c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces MessageDescriptor, FieldDescriptor, EnumDescriptor and
supporting types as the processed, feature-resolved layer on top of the
raw FileDescriptorProto tree. Where raw protos use string type_name
references and unresolved FeatureSet options, these use pool indices
(MessageIndex/EnumIndex, avoiding Arc cycles) and pre-resolved edition
features (FieldPresence, packed, delimited).
FieldKind flattens protobuf's type × label × map-entry axes into a
single Copy discriminant via a SingularKind sub-enum — invalid states
like List(List(...)) are unrepresentable, and no Box allocation is
needed.
These types are constructed by DescriptorPool (next PR) and consumed by
DynamicMessage. #[non_exhaustive] with pub fields allows reads without
external construction.