fix(files): infer document upload content types#198
Open
jeet-dekivadia wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Author
|
Small follow-up while this is waiting for review. The content-type inference only fills in common document uploads by filename extension when the caller has not already supplied an explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/pdfandtext/plainfor multipart files with.pdfand.txtfilenamesAnthropic::FilePart#content_typevalues authoritativeapplication/octet-streamfallback for unknown formats and add focused regression coverageAddresses #128.
Validation
git diff --checkFile.extnamehandling forPathname, missing filenames, and uppercase extensionsRemote Linux validation
git diff --checkbundle install./scripts/lint./scripts/test