Skip to content

fix: resolve x-stainless-timeout when request timeout is NotGiven #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KirtiRamchandani wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −3
Open

fix: resolve x-stainless-timeout when request timeout is NotGiven #1677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/anthropic/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,11 +456,17 @@ def _make_status_error(

def _build_headers(self, options: FinalRequestOptions, *, retries_taken: int = 0) -> httpx.Headers:
custom_headers = options.headers or {}
req_timeout = self.timeout if isinstance(options.timeout, NotGiven) else options.timeout
if isinstance(req_timeout, Timeout):
stainless_timeout = str(req_timeout.read)
elif req_timeout is not None:
stainless_timeout = str(req_timeout)
else:
default_timeout = self.timeout
stainless_timeout = str(default_timeout.read if isinstance(default_timeout, Timeout) else default_timeout)
headers_dict = _merge_mappings(
{
"x-stainless-timeout": str(options.timeout.read)
if isinstance(options.timeout, Timeout)
else str(options.timeout),
"x-stainless-timeout": stainless_timeout,
**self.default_headers,
},
custom_headers,
Expand Down
7 changes: 7 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,13 @@ def test_default_headers_option(self) -> None:
test_client.close()
test_client2.close()

def test_default_timeout_header_is_not_not_given(self) -> None:
client = Anthropic(base_url=base_url, api_key=api_key, _strict_response_validation=True)
request = client._build_request(FinalRequestOptions(method="get", url="/foo"))
assert request.headers.get("x-stainless-timeout") != "NOT_GIVEN"
assert request.headers.get("x-stainless-timeout") == request.headers.get("x-stainless-read-timeout")
client.close()

def test_validate_headers(self) -> None:
client = Anthropic(base_url=base_url, api_key=api_key, _strict_response_validation=True)
request = client._build_request(FinalRequestOptions(method="get", url="/foo"))
Expand Down