Skip to content

fix: omit empty comma array query params #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ynachiket wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Open

fix: omit empty comma array query params #1656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/anthropic/_qs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,10 @@ def _stringify_item(
if isinstance(value, (list, tuple)):
array_format = opts.array_format
if array_format == "comma":
return [
(
key,
",".join(self._primitive_value_to_str(item) for item in value if item is not None),
),
]
serialised = ",".join(self._primitive_value_to_str(item) for item in value if item is not None)
if not serialised:
return []
return [(key, serialised)]
elif array_format == "repeat":
items = []
for item in value:
Expand Down
3 changes: 3 additions & 0 deletions tests/test_qs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ def test_array_comma(method: str) -> None:
assert unquote(serialise({"in": ["foo", "bar"]})) == "in=foo,bar"
assert unquote(serialise({"a": {"b": [True, False]}})) == "a[b]=true,false"
assert unquote(serialise({"a": {"b": [True, False, None, True]}})) == "a[b]=true,false,true"
assert unquote(serialise({"a": []})) == ""
assert unquote(serialise({"a": [None]})) == ""
assert unquote(serialise({"a": {"b": []}})) == ""


def test_array_repeat() -> None:
Expand Down