fix(completion): hide internal commands on initial tab#57
Closed
jeet-dekivadia wants to merge 1 commit into
Closed
fix(completion): hide internal commands on initial tab#57jeet-dekivadia wants to merge 1 commit into
jeet-dekivadia wants to merge 1 commit into
Conversation
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Author
|
Closing to avoid overlapping review surface while #55 is already refactoring the completion command path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The non-empty completion path already skips
child.Hidden, but the initial empty-input branch did not. As a result, the first tab completion could expose internal commands such as__complete,@completion, and@manpages. Applying the same visibility rule in both branches keeps shell completion aligned with the CLI's public surface.Validation
git diff --checkgo test ./internal/autocomplete -count=1