Open
Conversation
- see Herb Sutter's talk - https://herbsutter.com/gotw/_102/
- `std::result_of` was deprecated as of C++17, and removed in C++20 - opt for `std::invoke_result_t` in its place for all instances - also improves brevity
- move and move-assignment operations should not throw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight tweaks to address deprecations, unnecessary calls to
operator newand use ofnoexceptwith move(-assignment) operations.There also appears to be a data race when using one of the multithreaded queue implementations from Chapter 6, although this could be as a result of my changes, so I'm open to feedback while I go back to verify with the original implementation.
Possible results - (click to expand / collapse)
...produces similar results.