fix: Some issues <session>.is_active +1385523#4763
Conversation
prmukherj
requested review from
hpohekar,
mayankansys,
mkundu1 and
seanpearsonuk
as code owners
There was a problem hiding this comment.
Pull request overview
This PR addresses three key issues: enhancing the health checking mechanism for solver sessions, resolving command name conflicts in settings, and improving file handling cleanup in the datamodel service.
Key Changes:
- Deprecated
is_server_healthy()in favor of an enhancedis_active()that checks both connection and server health status - Removed "list" and "list-properties" from exposed command names to prevent clashes with internal classes
- Ensured
after_execute()always runs whenbefore_execute()has been called, using try-finally pattern
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ansys/fluent/core/solver/flobject.py | Filters out "list" and "list-properties" commands to avoid naming conflicts |
| src/ansys/fluent/core/session.py | Deprecates is_server_healthy(), enhances is_active() to include health check, and imports deprecation utility |
| src/ansys/fluent/core/services/datamodel_se.py | Refactors file handling to guarantee cleanup via try-finally pattern |
| doc/deprecated_pyfluent_apis.py | Updates documentation to reflect new deprecation target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prmukherj
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Context
These are completely separate issues (just for the benefit of all readers):
'is_active' was not checking for the health status of the server. Suppose a scenario, where we connect to an existing solver and that solver crashes, the connected solver would still be active, that is resolved here.
1385523 - Fluent side bug was also resolved here.
Change Summary
Impact