Skip to content

feat(hdf5): assign .h5 files to hdf5 key #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PProfizi merged 5 commits into from
Dec 16, 2025
Merged

feat(hdf5): assign .h5 files to hdf5 key #2838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2b1897
Assign .h5 files to hdf5 key
PProfizi Dec 12, 2025
c7b2971
Add test
PProfizi Dec 15, 2025
c6c4198
Apply suggestions from code review
PProfizi Dec 15, 2025
d433850
Merge branch 'main' into feat/automatic_key_for_h5_files
moe-ad Dec 15, 2025
e88e478
Key is h5dpf and not hdf5
PProfizi Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ansys/dpf/core/data_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ def set_result_file_path(
# Look for another extension for .h5 and .cff files
if key == "" and extension in [".h5", ".cff"]:
key = self.guess_second_key(str(filepath))
if key == "" and extension == ".h5":
key = "h5dpf"
if key == "":
self._api.data_sources_set_result_file_path_utf8(self, str(filepath))
else:
Expand Down
5 changes: 5 additions & 0 deletions tests/test_datasources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,11 @@ def test_set_resultpath_data_sources_cff(server_type):
assert data_sources.result_key == "cas"


def test_auto_key_data_sources_h5dpf(server_type):
data_sources = dpf.core.DataSources(result_path="test.h5", server=server_type)
assert data_sources.result_key == "h5dpf"


def test_set_resultpath_data_sources_cfx_res(server_type):
from ansys.dpf.core import examples

Expand Down