Skip to content

Conversation

@ansys-akarcher
Copy link
Contributor

No description provided.

joshuafairch and others added 30 commits November 13, 2025 15:19
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: Rafael Canton <107186344+rafacanton@users.noreply.github.com>
Co-authored-by: Paul Profizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <paul.profizi@ansys.com>
Co-authored-by: Rajesh Meena <60212378+rajesh1359@users.noreply.github.com>
Co-authored-by: Paul Profizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <paul.profizi@ansys.com>
… animations (#1700)

Co-authored-by: Rajesh Meena <60212378+rajesh1359@users.noreply.github.com>
Co-authored-by: Rajesh Meena <rajesh2902@gmai.cim>
Co-authored-by: Paul Profizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PyAnsys CI Bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
@rafacanton rafacanton marked this pull request as ready for review December 9, 2025 15:34
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use the ansys.tools.common.cyberchannel module inside the ansys-tools-common package rather than a local copy of the cyberchannel module? We are pushing all teams for this request

@PProfizi
Copy link
Contributor

Would it be possible to use the ansys.tools.common.cyberchannel module inside the ansys-tools-common package rather than a local copy of the cyberchannel module? We are pushing all teams for this request

@RobPasMue we are going to merge a first version of this PR as soon as possible to allow for changes server-side, but later work Python side will include using the ansys-tools-common library as well as writing all the necessary documentation.

Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last remark is that yo set env var to insecure in basically all pipelines (I guess to quickly have something passing) but this means you never actually test the secure channel config.

@RobPasMue
Copy link
Member

Would it be possible to use the ansys.tools.common.cyberchannel module inside the ansys-tools-common package rather than a local copy of the cyberchannel module? We are pushing all teams for this request

@RobPasMue we are going to merge a first version of this PR as soon as possible to allow for changes server-side, but later work Python side will include using the ansys-tools-common library as well as writing all the necessary documentation.

Okay sounds good, thanks @PProfizi !

@rafacanton
Copy link
Contributor

Last remark is that yo set env var to insecure in basically all pipelines (I guess to quickly have something passing) but this means you never actually test the secure channel config.

This is the issue remarked by codecov btw. On another note @ansys-akarcher, can you please address the small issues from Codacy? Just a couple of imports

@rafacanton rafacanton dismissed RobPasMue’s stale review December 15, 2025 13:21

As detailed, we will use it in a later stage

@rafacanton rafacanton merged commit b59e7ab into main Dec 15, 2025
45 checks passed
@rafacanton rafacanton deleted the fix/grpc_changes branch December 15, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.