Skip to content

Use ansys.tools.common for example data download#990

Open
greschd wants to merge 1 commit into
mainfrom
maint/use_tools_common_for_example_data
Open

Use ansys.tools.common for example data download#990
greschd wants to merge 1 commit into
mainfrom
maint/use_tools_common_for_example_data

Conversation

@greschd

@greschd greschd commented Jun 30, 2026

Copy link
Copy Markdown
Member
  • Use ansys.tools.common.example_download for downloading data from the ansys/example-data repository instead of directly downloading with urllib.
  • The download is still wrapped in our own function to keep the enum-based interface for the example data.

Resolves #968

- Use ansys.tools.common.example_download for downloading data
  from the `ansys/example-data` repository instead of directly
  downloading with urllib.
- The download is still wrapped in our own function to keep the
  enum-based interface for the example data.
@greschd greschd requested review from SRaimondi and roosre as code owners June 30, 2026 08:05
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.89%. Comparing base (ce6851d) to head (28b4b97).

Files with missing lines Patch % Lines
src/ansys/acp/core/extras/example_helpers.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   93.90%   93.89%   -0.01%     
==========================================
  Files         110      110              
  Lines        5902     5898       -4     
  Branches      332      332              
==========================================
- Hits         5542     5538       -4     
  Misses        354      354              
  Partials        6        6              
Flag Coverage Δ
direct-launch 90.97% <33.33%> (-0.01%) ⬇️
minimum-deps 91.99% <33.33%> (-0.01%) ⬇️
python-3.11 93.06% <33.33%> (-0.01%) ⬇️
python-3.12 93.06% <33.33%> (-0.01%) ⬇️
python-3.13 93.06% <33.33%> (-0.01%) ⬇️
python-3.14 93.29% <33.33%> (-0.01%) ⬇️
server-2024R2SP5 89.52% <33.33%> (-0.01%) ⬇️
server-2025R1SP4 93.09% <33.33%> (-0.01%) ⬇️
server-2025R2SP3 93.05% <33.33%> (-0.01%) ⬇️
server-2026R1 93.05% <33.33%> (-0.01%) ⬇️
server-latest 93.65% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate the example download from custom implementation to ansys-tools-common

1 participant