fix: doc-deploy-dev needs pr write permission

[inimaz]

Closes #1391. But I am not sure, how to test this?

[SMoraisAnsys]

Many of our actions do require specific permissions and that's documented both in the associated examples and the actions description (see my "Here" comment). I'm not opposed to adding this kind of error handling but we would have to do it for the other actions too if that's the case :)

[SMoraisAnsys]

Here

[SMoraisAnsys]

Closes #1391. But I am not sure, how to test this?

You can just try your branch on a public repo you manage / have access to. Instead of pointing to the tag with its hash, you can leverage your branch name.

[inimaz]

Ah nice, thanks for the review @SMoraisAnsys !
My problem was that it did work for long time without the pull-requests: write permission. Then when I added the other deploy-doc-pr job, it suddenly stopped working with no warning/error. Maybe we can add a common check to all jobs and fail or add a warning if the permissions are not there? It might be overkill.

[SMoraisAnsys]

Ah nice, thanks for the review @SMoraisAnsys ! My problem was that it did work for long time without the pull-requests: write permission. Then when I added the other deploy-doc-pr job, it suddenly stopped working with no warning/error. Maybe we can add a common check to all jobs and fail or add a warning if the permissions are not there? It might be overkill.

I'm fine with adding that check but we should be consistent and apply it in other locations where we are the one managing the code that requires specific permission. In the cases where we consume third party actions (with specific permissions requirements), I wouldn't want to add things like continue-on-error just to log an error message that is probably already explained by the third party action.

[inimaz]

I'm fine with adding that check but we should be consistent and apply it in other locations where we are the one managing the code that requires specific permission. In the cases where we consume third party actions (with specific permissions requirements), I wouldn't want to add things like continue-on-error just to log an error message that is probably already explained by the third party action.

I completely agree. I would say just check the permissions that are in the description and we know are needed for the part of the action we manage.