Skip to content

feat(opencode): fff search tools#27802

Open
dmtrKovalenko wants to merge 1 commit into
anomalyco:devfrom
dmtrKovalenko:feat/fff-search-tools
Open

feat(opencode): fff search tools#27802
dmtrKovalenko wants to merge 1 commit into
anomalyco:devfrom
dmtrKovalenko:feat/fff-search-tools

Conversation

@dmtrKovalenko
Copy link
Copy Markdown

Issue for this PR

Closes #<you guys know right?>

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This implements fff pickers for the all file search operation - file search, content search, directories & mixed search.

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

bun test
bun dev .
bun run bench-fff.ts

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:title labels May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hey! Your PR title Feat/fff search tools doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on the search results, I found 2 potentially related PRs that address similar fff search functionality:

  1. PR feat: switch file search to fff #18419 - feat: switch file search to fff

  2. PR feat(search): add runtime-aware search service with fff #23890 - feat(search): add runtime-aware search service with fff

Why they're related: All three PRs focus on integrating fff (a fuzzy file finder) with the search functionality. PR #27802 implements fff pickers for file search, content search, directories, and mixed search - which could potentially be addressing the same feature set as the earlier PRs.

You may want to check if these earlier PRs were completed, merged, or abandoned to determine if #27802 is a duplicate effort or a continuation/improvement of prior work.

@dmtrKovalenko dmtrKovalenko changed the title Feat/fff search tools feat: fff search tools May 15, 2026
@github-actions github-actions Bot removed needs:title needs:compliance This means the issue will auto-close after 2 hours. labels May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@dmtrKovalenko dmtrKovalenko changed the title feat: fff search tools feat(opencode): fff search tools May 15, 2026
@dmtrKovalenko dmtrKovalenko force-pushed the feat/fff-search-tools branch 5 times, most recently from 359023d to c53db50 Compare May 16, 2026 00:33
)
}

if (result.hasNextPage) {
Copy link
Copy Markdown
Author

@dmtrKovalenko dmtrKovalenko May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is replaces the truncated message above. Needed because fff doesn't perform the full search once it found requested amount (there could be a bit more if certain file contains a ton of results as the internal pagination is happening over files)

This saves a ton of system resources on large directories when we can reduce amount of syscalls spent on opening and reading files

Co-Authored-By: Shoubhit Dash <shoubhit2005@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant