-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(windows): add arm64 release targets for cli and desktop #16299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,11 @@ export const SIDECAR_BINARIES: Array<{ rustTarget: string; ocBinary: string; ass | |
| ocBinary: "opencode-darwin-x64-baseline", | ||
| assetExt: "zip", | ||
| }, | ||
| { | ||
| rustTarget: "aarch64-pc-windows-msvc", | ||
| ocBinary: "opencode-windows-arm64", | ||
| assetExt: "zip", | ||
| }, | ||
|
Comment on lines
+14
to
+18
|
||
| { | ||
| rustTarget: "x86_64-pc-windows-msvc", | ||
| ocBinary: "opencode-windows-x64-baseline", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPENCODE_VERSIONis read intoversionand then used to build download URLs (viav${version}), but earlier in this script the guard mistakenly checksreleaseIda second time instead of validatingversion. IfOPENCODE_VERSIONis unset, this will silently generatevundefinedURLs for all targets (including the new Windows arm64 entry). Update the env var validation to throw whenversionis missing.