fix(tui): pass roots:true in session list bootstrap to fix child session dilution#16273
Open
dinhphieu wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): pass roots:true in session list bootstrap to fix child session dilution#16273dinhphieu wants to merge 1 commit intoanomalyco:devfrom
dinhphieu wants to merge 1 commit intoanomalyco:devfrom
Conversation
3 tasks
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16270
Closes #13877
Type of change
What does this PR do?
The TUI session list bootstrap in
sync.tsxfetches sessions without passingroots: true. This means root sessions and child sessions (forks, compaction) are mixed together.Session.list()defaults toLIMIT 100, and the TUI dialog filters client-side with.filter(x => x.parentID === undefined).For users who spawn subagents/tasks heavily, child sessions vastly outnumber roots. In my case: top 100 by
time_updatedcontains 95 children and only 5 roots. So/sessionsshows ~5 conversations despite 584 existing in the DB.Fix: add
roots: trueto the bootstrap call so the server appliesWHERE parent_id IS NULLbefore the limit. All 100 slots go to actual conversations.How did you verify your code works?
Verified against a production DB with 8,976 sessions (584 root, rest children):
Screenshots / recordings
N/A — not a UI change, just a query parameter fix.
Checklist