fix(app): improve desktop project switching performance#16251
Open
kunish wants to merge 1 commit intoanomalyco:devfrom
Open
fix(app): improve desktop project switching performance#16251kunish wants to merge 1 commit intoanomalyco:devfrom
kunish wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16256
Type of change
What does this PR do?
This PR improves desktop project switching responsiveness by reducing synchronous work on the switch path.
Main changes:
topRootSessions,latestRootSession,nextRootStart)navigateToProjectwith fast-path logic and fewer blocking updatesHow did you verify your code works?
bun typecheck(packages/app)PLAYWRIGHT_PORT=4444 bun test:e2e -- e2e/projects/projects-switch.spec.tsbun test:e2e:local -- e2e/projects/projects-switch.spec.tsScreenshots / recordings
No UI visuals attached for this round.
Checklist