feat: make possible to hide the whiteboard toolbar#20274

Merged

lukstbit merged 2 commits intoankidroid:mainfrom

BrayanDSO:feat/whiteboard-hide5

Feb 6, 2026

Member

BrayanDSO commented Jan 31, 2026

Purpose / Description

The biggest complaint about the new whiteboard was the screen space that it consumed.

So, I'm adding a way to hide it by dragging it outside the screen.

Fixes

Fixes New study screen: make possible to hide the Whiteboard toolbar #19793

Approach

Add a menu option to make it more discoverable
Add an invisible touch area around the toolbar so it's easier to drag it
Deal with all the logic of hiding/showing the toolbar by dragging it

How Has This Been Tested?

Galaxy Tab S9, Android 16

Screen_Recording_20260131_171704_AnkiDroid.mp4

Learning (optional, can help others)

Despite the branch name, it's probably the 7th thing I tried. I don't like much to deal with moving and animating stuff in Android

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

Contributor

github-actions bot commented Jan 31, 2026

Important

Maintainers: This PR contains Strings changes

Sync Translations before merging this PR and wait for the action to complete
Review and merge the auto-generated PR in order to sync all user-submitted translations
Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

github-actions bot added Strings Needs Review labels

BrayanDSO force-pushed the feat/whiteboard-hide5 branch from 32230d8 to e74a5c5 Compare

January 31, 2026 20:30

BrayanDSO marked this pull request as draft

January 31, 2026 20:34

BrayanDSO force-pushed the feat/whiteboard-hide5 branch from e74a5c5 to bd1395d Compare

January 31, 2026 20:45

BrayanDSO marked this pull request as ready for review

January 31, 2026 20:46

david-allison approved these changes

View reviewed changes

Member

david-allison left a comment

Looks FANTASTIC. Wow.

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/WhiteboardToolbar.kt Outdated Show resolved Hide resolved

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/WhiteboardFragment.kt Outdated

Comment on lines 207 to 209

+                              if (!isShown) {
+                                  hideToolbar()
+                              }

Member

david-allison Feb 1, 2026

Is it possible to sync the UI state here on both show & hide?

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/WhiteboardToolbar.kt Outdated

-                      binding.innerControlsLayout.orientation = if (isVertical) LinearLayout.VERTICAL else LinearLayout.HORIZONTAL
+                      currentAlignment = alignment
+                      val isVertical = alignment == ToolbarAlignment.LEFT || alignment == ToolbarAlignment.RIGHT

Member

david-allison Feb 1, 2026

nit: this is unintuitive, comment, naming change or adding a property to ToolbarAlignment

Member Author

BrayanDSO Feb 2, 2026

went with:

        // Check if the toolbar is docked to a side edge (Left/Right).
        val isSideDocked = alignment == ToolbarAlignment.LEFT || alignment == ToolbarAlignment.RIGHT

not sure if it is good enough

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/WhiteboardToolbar.kt Outdated Show resolved Hide resolved

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/WhiteboardToolbar.kt

Comment on lines +206 to +219

		val dx = event.rawX - dragStartX
		val dy = event.rawY - dragStartY

Member

david-allison Feb 1, 2026

nit: I don't think it's worth it, but a Point class would allow:

val (dx, dy) = event.toPoint() - dragStart

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/WhiteboardToolbar.kt Outdated Show resolved Hide resolved

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/WhiteboardToolbar.kt Outdated Show resolved Hide resolved

david-allison added Needs Author Reply Needs Second Approval and removed Needs Review labels

github-actions bot added the Has Conflicts label


          feat: menu option to hide the whiteboard toolbar

203b0a9

the rest of the implementation will be in the next commit.

Split to ease the review process.

BrayanDSO force-pushed the feat/whiteboard-hide5 branch from bd1395d to fc4dfc5 Compare

February 5, 2026 20:05


          feat: hide whiteboard toolbar

4743a13

BrayanDSO force-pushed the feat/whiteboard-hide5 branch from fc4dfc5 to 4743a13 Compare

February 5, 2026 20:29

BrayanDSO removed Needs Author Reply Has Conflicts labels

lukstbit approved these changes

View reviewed changes

Member

lukstbit left a comment

Not going to use this myself but the functionality is nice.

The side positioning makes it a bit harder to hide/show as it's in the path of the predictive gesture but it's not that important.

lukstbit added Pending Merge and removed Needs Second Approval labels

lukstbit added this pull request to the merge queue

Merged via the queue into ankidroid:main with commit 2877c2f

15 checks passed

github-actions bot added this to the 2.24 release milestone

Contributor

github-actions bot commented Feb 6, 2026

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

github-actions bot removed the Pending Merge label

lukstbit mentioned this pull request

Updated strings from Crowdin 2026/02/06 19:02 #20302

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels