Allow enum name to differ from column name#7
Open
emilong wants to merge 1 commit intoankane:masterfrom
Open
Conversation
|
This seems really valuable as we're evaluating moving our existing enums to str_enums. It seems like it's been a while since this was opened, but thoughts on merging @ankane? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that while migrating some existing Rails
enumcolumns tostr_enum, I wanted a way to havestr_enum"take over" the oldenumname and generated methods while pointing at a new column so I could keep both columns for a smooth transition.To that end, I added another option to
str_enumcalled:columnwhere you can specify the column explicitly.It doesn't seem to have created any regressions as far as I can tell from the test suite or require a major version bump.
Hoping this might be useful for other folks too!