fix: cross-compilation linker in release workflow#3
Merged
Conversation
The ~/.cargo/config.toml approach fails inside the devcontainer because CARGO_HOME points elsewhere. Use the CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER env var instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the aarch64 cross-compilation failure in the release workflow.
Problem:
~/.cargo/config.tomllinker config wasn't being picked up inside the devcontainer becauseCARGO_HOMEpoints to/usr/local/cargo, not~/.cargo.Fix: Use the
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKERenv var instead — this always works regardless of cargo home location.