Conversation
TEMP Remove all but 7 SI quantities Add Duration and Length projects TEMP Remove non-SI unit definitions Add UnitsNet.SI, move SI stuff there Include the 8 quantity projects in solution
Closed
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Owner
Author
|
test comment |
Owner
Author
|
test 2 |
Owner
Author
|
test 3 |
Owner
Author
|
test 4 |
Owner
Author
|
test 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #372, #1180
Experiment with splitting up UnitsNet nuget into:
This is already done for UnitsNet.nanoFramework nugets:
https://www.nuget.org/packages?q=unitsnet.nanoframework
We might also provide meta nuget packages that bring in multiple nugets in a single package:
Benefits
UnitsNet.dllis ~2MB as of 2023-01-07.Problems
QuantityTypeenum must be replaced by strings and usingQuantityInfoinsteadUnitSystemandBaseUnitsrely on the 7 SI quantities Length, Mass, etc.Speed = Length / DurationandMass.FromGravitationalForce(Force f). We might be able to provide this with meta nuget packages that bring in the most common quantities and arithmetic/conversions between them.Design proposal
QuantityInfoto fully describe a quantity, instead of relying on generated code for known quantities spread over various types.UnitAbbreviationsCache.LoadGeneratedAbbreviations()based on generated code.Acceleration.RegisterDefaultConversionsand similar for other quantities.