refactor(github-actions): move publish-ci logic to custom GHA action#3785
Open
josephperrott wants to merge 3 commits into
Open
refactor(github-actions): move publish-ci logic to custom GHA action#3785josephperrott wants to merge 3 commits into
josephperrott wants to merge 3 commits into
Conversation
Moves PublishCiTool and its unit tests from ng-dev CLI to a new custom GitHub Action at github-actions/release/publish. The action handles token generation using the Angular Robot App key internally. Reusable workflow is updated to call this action.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the publish-ci release publishing tool from a CLI command in ng-dev to a dedicated GitHub Action under github-actions/release/publish. It removes the publish-ci command from the ng-dev CLI, deletes the old CLI implementation, and introduces the new GitHub Action configuration, entry point, and Bazel build targets. Additionally, visibility rules in several ng-dev packages have been updated to support the new action. There are no review comments, and I have no further feedback to provide.
Adds the generated main.js to .prettierignore to prevent it from being formatted during commit, resolving the buildifier/prettier comparison test failure. Also adds missing dependencies (config, notes, versioning) to the test_lib target in BUILD.bazel.
Formats publish-ci.ts using prettier and regenerates the checked-in main.js bundle to match the formatted source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves PublishCiTool and its unit tests from ng-dev CLI to a new custom GitHub Action at github-actions/release/publish. The action handles token generation using the Angular Robot App key internally. Reusable workflow is updated to call this action.