Skip to content

refactor(ng-dev): remove rules_* repositories from ManagedRepositories#3547

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:managed
Mar 16, 2026
Merged

refactor(ng-dev): remove rules_* repositories from ManagedRepositories#3547
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:managed

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

These are now considered as snapshot builds repos

These are now considered as snapshot builds repos
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 16, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes rules_angular, rules_browsers, and rules_sass from the ManagedRepositories enum in ng-dev/pr/common/labels/base.ts. This aligns with the description that these are now considered snapshot build repositories. The changes are straightforward and correctly remove the specified repositories. No issues were found during the review.

Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 merged commit 0c9cddc into angular:main Mar 16, 2026
13 checks passed
@alan-agius4
Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the managed branch March 16, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants