build: refine module synchronization#3524
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 13, 2026
Merged
Conversation
angular-robot
bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates TypeScript to version 5.9.3 across the workspace and refines the sync-all-modules.sh script. The dependency updates appear correct and consistent with the goal of the PR. The script modification, which adds an update to the root lockfile within the synchronization loop, is a logical improvement for handling circular dependencies as described. I have one suggestion to enhance the robustness of the script.
alan-agius4
added
action: merge
alan-agius4
changed the title
Also refines the sync-all-modules.sh script to update the root lockfile during the synchronization pass. This ensures the root lockfile is accurate between module synchronization steps, which is necessary for pnpm ng-dev misc sync-module-bazel to function correctly when dealing with circular dependencies.
crisbeto
approved these changes
Mar 13, 2026
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also refines the sync-all-modules.sh script to update the root lockfile during the synchronization pass. This ensures the root lockfile is accurate between module synchronization steps, which is necessary for pnpm ng-dev misc sync-module-bazel to function correctly when dealing with circular dependencies.