fix(bazel): handle additional cases for strict deps testing#2988
Closed
josephperrott wants to merge 1 commit intoangular:mainfrom
Closed
fix(bazel): handle additional cases for strict deps testing#2988josephperrott wants to merge 1 commit intoangular:mainfrom
josephperrott wants to merge 1 commit intoangular:mainfrom
Conversation
josephperrott
force-pushed
the
fix-strict-deps-test
branch
from
84b6d66 to
1ef4188
Compare
josephperrott
force-pushed
the
fix-strict-deps-test
branch
from
1ef4188 to
281a39a
Compare
josephperrott
requested review from
alan-agius4
and removed request for
clydin
alan-agius4
approved these changes
Aug 25, 2025
Contributor
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, couple of NITs
alan-agius4
reviewed
Aug 25, 2025
josephperrott
force-pushed
the
fix-strict-deps-test
branch
2 times, most recently
from
4bb821c to
b3dc431
Compare
Properly handle module names that come with packages in DefinitelyTyped Properly handle module names that are described within tsconfig paths configuration Properly handle edge case of `zone.js` containing an extension in its name
josephperrott
force-pushed
the
fix-strict-deps-test
branch
from
b3dc431 to
15b3a1b
Compare
Member
Author
|
This PR was merged into the repository by commit acce054. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle module names that come with packages in DefinitelyTyped Properly handle module names that are described within tsconfig paths configuration Properly handle edge case of
zone.jscontaining an extension in its name