Skip to content

fix(cdk/accordion): replace hardcoded colors with theme tokens #33388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BHUVANSH855 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

fix(cdk/accordion): replace hardcoded colors with theme tokens #33388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...mponents-examples/cdk/accordion/cdk-accordion-overview/cdk-accordion-overview-example.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

.example-accordion-item {
display: block;
border: solid 1px #ccc;
border: 1px solid var(--mat-sys-outline-variant);

@crisbeto crisbeto Jun 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally don't use Material concepts in the CDK since the CDK is supposed to be independent of Material.

@BHUVANSH855 BHUVANSH855 Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @crisbeto. My goal was to improve the example's appearance in dark mode, but I understand that CDK examples shouldn't depend on Material theme tokens.

Would you prefer that this example continue using hardcoded colors, or would a CDK-neutral approach based on CSS system colors be acceptable?

}

.example-accordion-item + .example-accordion-item {
Expand All @@ -21,12 +21,11 @@
border: none;
padding: 16px;
text-align: left;

}

.example-accordion-item-description {
font-size: 0.85em;
color: #999;
color: var(--mat-sys-on-surface-variant);
}

.example-accordion-item-body {
Expand All @@ -35,7 +34,7 @@

.example-accordion-item-header:hover {
cursor: pointer;
background-color: #eee;
background-color: var(--mat-sys-surface-container);
}

.example-accordion-item:first-child {
Expand Down
Loading