Make this library 'developer-friendly'#31
Open
AshBardhan wants to merge 12 commits intoandyshora:masterfrom
Open
Make this library 'developer-friendly'#31AshBardhan wants to merge 12 commits intoandyshora:masterfrom
AshBardhan wants to merge 12 commits intoandyshora:masterfrom
Conversation
|
|
||
| 1. **Github** | ||
| - [unminified] : [angular-image-crop.js](https://raw.githubusercontent.com/AshBardhan/angular-image-crop/master/dist/angular-image-crop.js) and [angular-image-crop.css](https://raw.githubusercontent.com/AshBardhan/angular-image-crop/master/dist/angular-image-crop.css) | ||
| - [minified] : [angular-image-crop.min.js](https://raw.githubusercontent.com/AshBardhan/angular-image-crop/master/dist/angular-image-crop.min.js) and [angular-image-crop.min.css](https://raw.githubusercontent.com/AshBardhan/angular-image-crop/master/dist/angular-image-crop.min.css) |
Author
There was a problem hiding this comment.
@andyshora Once you merge this code. You've to change the link from https://raw.githubusercontent.com/AshBardhan/angular-image-crop/master/dist/angular-image-crop.min.js to https://raw.githubusercontent.com/andyshora/angular-image-crop/master/dist/angular-image-crop.min.js
Similarly do this for other files.
|
Why hasn't this been merged? |
Author
|
@andyshora Is there any issue I need to resolve? |
blavenie
added a commit
to duniter-cesium/angular-image-crop
that referenced
this pull request
Apr 13, 2020
- merge pull request andyshora#31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andy,
I've done the following changes in order to make this library:
src- the source raw files (where any one can change as required).dist- all the final build files and their minified versions.demo- some sampleindex.htmlandindex2.htmlfiles for testing.gruntnode packages and related tasks which will compile files insrcfolder intodistfolder.CONTRIBUTING.mdfile where development related steps are mentioned.bower.jsonby adding some ignored files, which won't be downloaded if user install this library from bower..gitignorefile.Hope to get quick response.
Thanks.